-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update translation.json for Spanish #6343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added some Spanish translation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
Thanks @baleriaa! Since the translation you did is about FES, I'm tagging the FES contributor/mentors this summer to double check @Ayush23Dash @almchung @nbriz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requested on one line, rest looks good. Thank you.
@@ -1,18 +1,18 @@ | |||
{ | |||
"fes": { | |||
"autoplay": "Su browser impidío un medio tocar (de '{{src}}'), posiblemente porque las reglas de autoplay. Para aprender más, visite {{link}}.", | |||
"checkUserDefinedFns": "", | |||
"autoplay": "Su browser impidío un medio tocar (de '{{src}}'), posiblemente por las reglas de autoplay. Para aprender más, visite {{link}}.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original is "The media that tried to play (with '{{src}}') wasn't allowed to by this browser, most likely due to the browser's autoplay policy.\n\n+ More info: {{url}}"
I suggest "navegador" instead of browser. Also the structure of the first sentence would be better in my opinion as: "Su navegador impidió la reproducción del contenido multimedia (de '{{src}}'.), posiblemente debido a las reglas de autoplay..."
Thanks @holomorfo for the suggestion. @baleriaa, could you adjust the translation based on the suggestion? After that, we can merge this PR. Thank you! |
I think I missed it somehow, this PR looks good to me. After implementing the suggestion, we can merge it. |
Changes:
There is the addition of Spanish text that mimics what is stated in the English file. There is also one small grammar correction of previously added text
npm run lint
passes