Skip to content

Update translation.json for Spanish #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

baleriaa
Copy link

Changes:
There is the addition of Spanish text that mimics what is stated in the English file. There is also one small grammar correction of previously added text

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

Added some Spanish translation
@welcome
Copy link

welcome bot commented Aug 17, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@Qianqianye
Copy link
Contributor

Thanks @baleriaa!
I'm tagging the Spanish translation stewards to review the updates: @Guirdo@Andreu-G@dnd-alv@holomorfo

Since the translation you did is about FES, I'm tagging the FES contributor/mentors this summer to double check @Ayush23Dash @almchung @nbriz

Copy link

@holomorfo holomorfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested on one line, rest looks good. Thank you.

@@ -1,18 +1,18 @@
{
"fes": {
"autoplay": "Su browser impidío un medio tocar (de '{{src}}'), posiblemente porque las reglas de autoplay. Para aprender más, visite {{link}}.",
"checkUserDefinedFns": "",
"autoplay": "Su browser impidío un medio tocar (de '{{src}}'), posiblemente por las reglas de autoplay. Para aprender más, visite {{link}}.",
Copy link

@holomorfo holomorfo Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original is "The media that tried to play (with '{{src}}') wasn't allowed to by this browser, most likely due to the browser's autoplay policy.\n\n+ More info: {{url}}"

I suggest "navegador" instead of browser. Also the structure of the first sentence would be better in my opinion as: "Su navegador impidió la reproducción del contenido multimedia (de '{{src}}'.), posiblemente debido a las reglas de autoplay..."

@Qianqianye Qianqianye added the Internationalization Relates to 'src/core/internationalization.js' label Aug 18, 2023
@Qianqianye
Copy link
Contributor

Thanks @holomorfo for the suggestion. @baleriaa, could you adjust the translation based on the suggestion? After that, we can merge this PR. Thank you!

@Ayush23Dash
Copy link
Contributor

I think I missed it somehow, this PR looks good to me. After implementing the suggestion, we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Friendly Errors Internationalization Relates to 'src/core/internationalization.js'
Projects
Status: FES i18n
Development

Successfully merging this pull request may close these issues.

4 participants