Skip to content

fix fill/stroke order bug #2511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2018
Merged

Conversation

Spongman
Copy link
Contributor

@Spongman Spongman commented Jan 7, 2018

this PR:

  • removed the shader.active flag which was getting out of sync, and just uses the existing _doFill/_doStroke style properties instead.
  • removed the redundant GL-specific noFill/noStroke methods.
  • delays setting the blend stuff until just before the draw call (since it's a global setting shared between fill & edge shaders).
  • removes some of the unnecessary usePrograms
  • fixes webgl: results dependend on order of stroke/fill calls #2509

@stalgiag
Copy link
Contributor

stalgiag commented Jan 7, 2018

Great idea! The organization of that section of the code is a lot better now. I don't have an opportunity to investigate deeply. Can you just flag me in some way when you feel that this is ready for a merge? I can run through it then.

@Spongman
Copy link
Contributor Author

Spongman commented Jan 7, 2018

oops, i forgot that i had to exclude the webgl examples from the tests, now that they're actually in the docs. should be good to go now, thx!

@stalgiag
Copy link
Contributor

stalgiag commented Jan 8, 2018

Cool so I just ran through a bunch of use scenarios and tests. I really like that this now falls in line with using _doFill/_doStroke along with the 2D renderer. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webgl: results dependend on order of stroke/fill calls
2 participants