Skip to content

Avoid direct modification of HTML #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PiyushChandra17
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 commented Jun 11, 2024

Fixes #2174

Changes:

  • Stored line number as a state and passed down as a prop in EditorAccessibility component
  • Since it is a class-based component, handled React state, componentDidMount, componentWillUnmount and props accordingly
  • In future, i guess we are going to convert this into Functional Component where useEffect hook will come into play

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for your work on this!

@raclim raclim merged commit a71d437 into processing:develop Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid direct modification of HTML
2 participants