Skip to content

add button to remove banner #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

Aseem22
Copy link
Contributor

@Aseem22 Aseem22 commented May 21, 2024

Fixes #3126

Changes: add a button that hides the banner at the top in web editor.

After:

processing_issue.3126.mp4

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Signed-off-by: Aseem <Aseempratap2207@gmail.com>
Copy link

welcome bot commented May 21, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for working on this!

I guess one thing to note is that the banner does reappear when you leave the home page (for example, opening your account page or the About modal) which is expected behavior, but might not be clear to a newer user. I don't think this is a major issue though, especially since this banner is temporary and will be taken down by the end of next week.

Thanks again for this, will deploy this soon!

@raclim raclim merged commit f8e1235 into processing:develop May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the newly header bar hideable
2 participants