Disable resizing the textarea in CollectionCreate modal
#2974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindapaiste
reviewed
Jan 28, 2024
| @@ -75,6 +75,7 @@ | |||
|
|
|||
| .form__input-flexible-height { | |||
| height: auto; | |||
| resize: none; | |||
lindapaiste
reviewed
Jan 28, 2024
| @@ -24,10 +24,9 @@ | |||
| display: flex; | |||
| flex-wrap: wrap; | |||
| flex-flow: column; | |||
| max-height: 80%; | |||
There was a problem hiding this comment.
This is the style for ALL modal, not just "create collection", so we need to tread carefully here. There are some larger modals like "keyboard shortcuts" where the max-height is required. It makes it so that the modal itself is limited in height and forces the content section of the modal to have a scrollbar if the contents won't fit.
There was a problem hiding this comment.
I apologize for the oversight, I failed to consider the potential utilization of this class for other modals.
There was a problem hiding this comment.
@lindapaiste, we can solve this issue using the :has() pseudo-class. I have made the commit you can check it.
lindapaiste
added
the
Area:CSS
lindapaiste
changed the title
CollectionCreate modal
raclim
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2973
Following changes are made in this pr :-
max-widthwhich was causing the overflowing of the 'Create collection' button.min-widthproperty when the screen width is650pxor less.I have verified that this pull request:
npm run lint)npm run test)developbranch.