Skip to content

Fixed: Translation of T&C on SignUp page #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Fixed: Translation of T&C on SignUp page #2847

merged 3 commits into from
Jan 6, 2024

Conversation

harmanbatheja15
Copy link
Contributor

Fixes issue #2846
Fixed: Translation of T&C on the SignUp page.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Jan 6, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well now I'm realizing that maybe I shouldn't have had you include the Hindi in the same PR because I can't verify that the Hindi text is correct 🙃. But I'm going to trust you on it and if anyone wants an alternate translation then they can open a PR to change it.

I ran your branch and switched the language to Hindi and I can see that the anchor texts of both links are getting translated so that's great ✔️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants