Skip to content

Use styled-components in CollectionListRow #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 13, 2024
Merged

Use styled-components in CollectionListRow #2799

merged 5 commits into from
Jun 13, 2024

Conversation

adityagarg06
Copy link
Contributor

@adityagarg06 adityagarg06 commented Dec 28, 2023 •
edited
Loading

Progress on #1760

Changes:

  • Migrate styles from client/styles/components/_sketch_list.scss into individual styled components in the client/modules/IDE/components/CollectionList/CollectionListRow.jsx file.
  • Looks identical to before on Windows Chrome.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

lindapaiste
lindapaiste reviewed Dec 28, 2023
View reviewed changes
client/theme.js Outdated
Comment on lines 257 to 259
modalBorderColor: grays.middleDark,
searchBackgroundColor: grays.darker,
tableRowStripeColor: grays.dark,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary due to the extend(baseThemes[Theme.dark]. We put that in as a helped to avoid having to repeat values which are the same as the dark theme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted redundant section.Thanks for pointing it out!

@lindapaiste
Copy link
Collaborator

This looks good at first glance. I wonder how it works alongside some of the pending PRs that I have re: common table components. I noticed that you didn't delete the classes from the .scss file. Possibly because they are used in multiple places? We have the same styles on multiple tables so possibly the conversion to styled-components becomes part of creating a common table component/system, where we have a TableBase with the core styles that can be extended or overwritten for specific tables.

@raclim raclim added Type:Task Tasks tied specifically to developer operations and maintenance Area:CSS For styling or layout issues handled with CSS/SASS labels Jan 26, 2024
@ceciliahollins ceciliahollins mentioned this pull request Jan 30, 2024
Open
@raclim raclim merged commit 8f4b9fd into processing:develop Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindapaiste lindapaiste lindapaiste left review comments

@raclim raclim raclim approved these changes

Assignees
No one assigned
Labels
Area:CSS For styling or layout issues handled with CSS/SASS Type:Task Tasks tied specifically to developer operations and maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityagarg06 @lindapaiste @raclim