Show an alert when leaving site with unsaved changes #2795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindapaiste
changed the title
raclim
approved these changes
Jan 8, 2024
| // beforeunload handles closing or refreshing the window. | ||
| useEffect(() => { | ||
| const handleUnload = (e) => { | ||
| // See: https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#browser_compatibility |
There was a problem hiding this comment.
Thanks for adding this, this is great! It would definitely be helpful to have more of these references/comments throughout the codebase!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2794
Discussion #2793
Changes:
beforeunloadhandler when closing the window with unsaved changes.Notes:
This will be a native browser alert and we cannot control the message text (in modern browsers). See MDN. The styling will depend on the user's browser theme.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123