Skip to content

Create tests for Toast component #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

lindapaiste
Copy link
Collaborator

Should be reviewed/merged after #2329

Changes:

  • Create unit tests for the end-to-end behavior of the Toast (check that it can be opened and closed).
  • Add an ARIA role to the Toast. I used status rather than alert because the lower priority seemed like it made more sense.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste added the Area: Testing For tests, test coverage, or testing infrastructure label Sep 3, 2023
@raclim raclim added this to the MINOR Release for 2.11.0 milestone Nov 30, 2023
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@raclim raclim merged commit 3778d18 into processing:develop Nov 30, 2023
@raclim raclim moved this from Reviewing in Progress to Done in PR Review Board May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing For tests, test coverage, or testing infrastructure
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants