Add autocomplete attributes to password forms - Fixes #2229 #2230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2229
Changes:
autoComplete
attributes to password input fields to help password managers. https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands/autoComplete="current-password"
on login or password verifyautoComplete="new-password"
on signup and password change/createautoComplete="email"
andautoComplete="username"
to complete the form.NewPasswordForm
because we should have a hidden input with the username.type="text"
totype="email"
on email fields. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/emailI have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123
Prior to this change, Chrome actually guesses wrong on the


/account
page. It shows the "Suggest a strong password" dialog on the "Current password" field and the "Manage passwords" dialog on the "New password" field. After the change it shows the correct one.