-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Refactor examples.js to use async/await #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for working on this! Your changes look great. One thing I would also suggest changing is the reliance on the library |
Okay, I'll be changing that! |
Could you please go through the changes? This is my first time working with the library |
Looking at this again, I also noticed that the |
Of course! Also, I replaced |
Fixes #1693
I have verified that this pull request:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)Fixes #123
@catarak please let me know if the changes are okay.