Skip to content

[WIP] Adding sketches to collections #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

andrewn
Copy link
Member

@andrewn andrewn commented Jul 8, 2019

Implementing features in #1115.

Editor API for Collections

Route Purpose Restrictions
GET /collections Fetch current user's collections Logged in user
GET /:username/collections Fetch a specific user's collections
POST /collections Create a new collection Logged in user
PATCH /collections/:id Update collection metadata Logged in user must own collection
DELETE /collections/:id Delete collection Logged in user must own collection
POST /collections/:id/:projectId Add a project to a collection Logged in user must own collection
DELETE /collections/:id/:projectId Remove a project from a collection Logged in user must own collection

To-do

  • Editor API for Collections
  • Controller tests
  • UI to list collections
  • UI to view a collection
  • UI to create/update/delete a collection
  • UI to add/remove a sketch from a collection
  • UI tests

Checks

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@andrewn
Copy link
Member Author

andrewn commented Jul 9, 2019

WIP UI for listing all collections:

Screenshot 2019-07-09 10 39 54

And WIP UI for viewing an indivuidual collection:

Screenshot 2019-07-09 10 40 09

The CollectionList and Collection components are mostly copy/pasted from the SketchList component. Once the UI has settled a bit, I'll try and figure out how to remove the duplication in these three components.

@andrewn andrewn force-pushed the feature/collections branch from 801d579 to 2d1bbe6 Compare July 9, 2019 16:24
@andrewn andrewn force-pushed the feature/collections branch from 2d1bbe6 to a15b191 Compare July 10, 2019 13:34
@andrewn
Copy link
Member Author

andrewn commented Sep 20, 2019

Closing this PR in favour of #1164.

@andrewn andrewn closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant