Skip to content

Commit 1aba99c

Browse files
authored
Merge pull request #1967 from processing/bug/phishing
Bug/phishing
2 parents effbddf + eaa14e3 commit 1aba99c

File tree

3 files changed

+31
-9
lines changed

3 files changed

+31
-9
lines changed

client/modules/IDE/components/ShareModal.jsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,14 @@ class ShareModal extends React.PureComponent {
1414
<h3 className="share-modal__project-name">{projectName}</h3>
1515
<CopyableInput
1616
label={this.props.t('ShareModal.Embed')}
17-
value={`<iframe src="${previewUrl}/${ownerUsername}/embed/${projectId}"></iframe>`}
17+
value={`<iframe src="${hostname}/${ownerUsername}/full/${projectId}"></iframe>`}
1818
/>
19-
<CopyableInput
19+
{/* CAT removing due to phishing issues */}
20+
{/* <CopyableInput
2021
label={this.props.t('ShareModal.Present')}
2122
hasPreviewLink
2223
value={`${previewUrl}/${ownerUsername}/present/${projectId}`}
23-
/>
24+
/> */}
2425
<CopyableInput
2526
label={this.props.t('ShareModal.Fullscreen')}
2627
hasPreviewLink

server/routes/embed.routes.js

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,25 @@
11
import { Router } from 'express';
22
import * as EmbedController from '../controllers/embed.controller';
33

4+
const editorUrl = process.env.EDITOR_URL;
5+
46
const router = new Router();
57

6-
router.get('/:username/embed/:project_id', EmbedController.serveProject);
7-
router.get('/:username/present/:project_id', EmbedController.serveProject);
8-
router.get('/embed/:project_id', EmbedController.serveProject);
8+
// CAT redirecting these temporarily to editor URLS to prevent phishing
9+
// router.get('/:username/embed/:project_id', EmbedController.serveProject);
10+
router.get('/:username/embed/:project_id', (req, res) => {
11+
const { username, project_id: projectId } = req.params;
12+
res.redirect(301, `${editorUrl}/${username}/full/${projectId}`);
13+
});
14+
// router.get('/:username/present/:project_id', EmbedController.serveProject);
15+
router.get('/:username/present/:project_id', (req, res) => {
16+
const { username, project_id: projectId } = req.params;
17+
res.redirect(301, `${editorUrl}/${username}/full/${projectId}`);
18+
});
19+
// router.get('/embed/:project_id', EmbedController.serveProject);
20+
router.get('/embed/:project_id', (req, res) => {
21+
const { project_id: projectId } = req.params;
22+
res.redirect(301, `${editorUrl}/full/${projectId}`);
23+
});
924

1025
export default router;

server/routes/redirectEmbed.routes.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,23 @@ const previewUrl = process.env.PREVIEW_URL;
55

66
router.get('/:username/embed/:project_id', (req, res) => {
77
const { username, project_id: projectId } = req.params;
8-
res.redirect(301, `${previewUrl}/${username}/embed/${projectId}`);
8+
// CAT changing due to ongoing phishing issues
9+
// res.redirect(301, `${previewUrl}/${username}/embed/${projectId}`);
10+
res.redirect(301, `/${username}/full/${projectId}`);
911
});
1012

1113
router.get('/:username/present/:project_id', (req, res) => {
1214
const { username, project_id: projectId } = req.params;
13-
res.redirect(301, `${previewUrl}/${username}/present/${projectId}`);
15+
// CAT changing due to ongoing phishing issues
16+
// res.redirect(301, `${previewUrl}/${username}/present/${projectId}`);
17+
res.redirect(301, `/${username}/full/${projectId}`);
1418
});
1519

1620
router.get('/embed/:project_id', (req, res) => {
1721
const { project_id: projectId } = req.params;
18-
res.redirect(301, `${previewUrl}/embed/${projectId}`);
22+
// CAT changing due to ongoing phishing issues
23+
// res.redirect(301, `${previewUrl}/embed/${projectId}`);
24+
res.redirect(301, `/full/${projectId}`);
1925
});
2026

2127
export default router;

0 commit comments

Comments
 (0)