Merge branch 'develop' into fix-docs-pr-template

Author: sdass1918

README.md

@@ -10,45 +10,36 @@ We are a community of, and in solidarity with, people from every gender identity
 
 Learn more about [our community](https://p5js.org/community/) and read our [Community Statement and Code of Conduct](./.github/CODE_OF_CONDUCT.md). You can directly support our work with p5.js by [donating to the Processing Foundation](https://processingfoundation.org/support).
 
-Stay in touch with Processing Foundation across other platforms: 
+Stay in touch with Processing Foundation across other platforms:
+
 - [Instagram](https://www.instagram.com/p5xjs)
 - [Youtube](https://www.youtube.com/@ProcessingFoundation)
 - [X](https://x.com/p5xjs)
 - [Discord](https://discord.com/invite/esmGA6H6wm)
 - [Forum](https://discourse.processing.org)
 
-
 ## Using the p5.js Editor 🤔
 
-Make your first sketch in the [p5.js Editor](https://editor.p5js.org/)! Learn more about sketching with p5.js on the [Get Started](https://p5js.org/tutorials/get-started/) and find everything you can do in the [Reference](https://p5js.org/reference/). You can also look at [examples](https://editor.p5js.org/p5/sketches) and remix them in the p5.js Editor. 
+Make your first sketch in the [p5.js Editor](https://editor.p5js.org/)! Learn more about sketching with p5.js on the [Get Started](https://p5js.org/tutorials/get-started/) and find everything you can do in the [Reference](https://p5js.org/reference/). You can also look at [examples](https://editor.p5js.org/p5/sketches) and remix them in the p5.js Editor.
 
-For more information on usage guidelines for the p5.js Editor, check out the [p5.js Editor Terms of Use](https://editor.p5js.org/terms-of-use). To gain better insight into how we handle user data and data privacy, refer to the [p5.js Editor Privacy Policy](https://editor.p5js.org/privacy-policy). 
+For more information on usage guidelines for the p5.js Editor, check out the [p5.js Editor Terms of Use](https://editor.p5js.org/terms-of-use). To gain better insight into how we handle user data and data privacy, refer to the [p5.js Editor Privacy Policy](https://editor.p5js.org/privacy-policy).
 
 ## Contributing 📖 🐛 🎨
 
-The p5.js Editor is a collaborative project created by many individuals, mostly volunteers, and you are invited to help. All types of involvement are welcome. To get started with contributing to the p5.js Editor, we recommend exploring the following resources in order: 
+The p5.js Editor is a collaborative project created by many individuals, mostly volunteers, and you are invited to help. All types of involvement are welcome. To get started with contributing to the p5.js Editor, we recommend exploring the following resources in order:
 
 1. [p5.js Community Statement and Code of Conduct](https://editor.p5js.org/code-of-conduct) - Read our Community Statement and Code of Conduct to understand the values that guide our community and how to participate respectfully and constructively.
 
 2. [Contributor Docs](https://github.com/processing/p5.js-web-editor/blob/develop/contributor_docs/README.md) - For a deeper look at how to get involved with the p5.js Editor, check out our Contributor Docs for more in-depth details about contributing to different areas of the project, including code, bug fixes, documentation, discussion, and more.
 
 3. [All Contributors list on the p5.js repository](https://github.com/processing/p5.js?tab=readme-ov-file#contributors) - Explore the All Contributors list to see the wide range of contributions by our amazing community!
 
-> **TypeScript Migration:** 
-> As of July 2025, we are working on migrating the repo to TypeScript as part of the **[p5.js Web Editor pr05 Grant](https://github.com/processing/pr05-grant/wiki/2025-pr05-Program-Page)**.  
-> This migration will occur in two phases:
-> 1. **Grant Work (July – October 31, 2025)** – Setting up TypeScript configuration, tooling, and starting partial migration. Contributions will be **closed** during this period.
-> 2. **Open Contribution (After October 31, 2025)** – TypeScript migration tasks will **open** to all contributors, with guidelines and tutorials available.  
+> **TypeScript Migration:** We have initiated migrating the repo to Typescript as part of the **[p5.js Web Editor pr05 Grant](https://github.com/processing/pr05-grant/wiki/2025-pr05-Program-Page)**, and the repo is now open to migration contributions.
 >
-> For full details, see [TypeScript Migration Plan](./contributor_docs/typescript-migration.md).
+> Please see [Typescript Migration](contributor_docs/typescript_migration.md) for migration guidelines. Please see [2025 pr05 Typescript Migration Project](contributor_docs/pr05_2025_typescript_migration/index.md) for details and technical decisions for the migration project.
 
 ## Acknowledgements 🙏
 
-Support for this project has come from [Processing Foundation](https://processingfoundation.org/), [NYU ITP](https://tisch.nyu.edu/itp), [CS4All, NYC DOE](http://cs4all.nyc/), [COSA at DU](https://liberalarts.du.edu/emergent-digital-practices/open-source-arts), [STUDIO for Creative Inquiry](https://studioforcreativeinquiry.org/), [Grant for the Web](https://www.grantfortheweb.org/), [New Media Rights](https://www.newmediarights.org/), and many others. 
+Support for this project has come from [Processing Foundation](https://processingfoundation.org/), [NYU ITP](https://tisch.nyu.edu/itp), [CS4All, NYC DOE](http://cs4all.nyc/), [COSA at DU](https://liberalarts.du.edu/emergent-digital-practices/open-source-arts), [STUDIO for Creative Inquiry](https://studioforcreativeinquiry.org/), [Grant for the Web](https://www.grantfortheweb.org/), [New Media Rights](https://www.newmediarights.org/), and many others.
 
-Hosting and technical support has come from: 
-<br />
-<br />
-<a href="https://releasehub.com/" target="_blank"><img width="100" src="https://assets.website-files.com/603dd147c5b0a480611bd348/603dd147c5b0a469bc1bd451_logo--dark.svg" /></a>
-<br />
-<a href="https://www.browserstack.com/" target="_blank"><img width="100" src="https://user-images.githubusercontent.com/6063380/46976166-ab280a80-d096-11e8-983b-18dd38c8cc9b.png" /></a>
+Hosting and technical support has come from: <br /> <br /> <a href="https://releasehub.com/" target="_blank"><img width="100" src="https://assets.website-files.com/603dd147c5b0a480611bd348/603dd147c5b0a469bc1bd451_logo--dark.svg" /></a> <br /> <a href="https://www.browserstack.com/" target="_blank"><img width="100" src="https://user-images.githubusercontent.com/6063380/46976166-ab280a80-d096-11e8-983b-18dd38c8cc9b.png" /></a>

client/index.jsx

@@ -23,7 +23,10 @@ const store = setupStore(initialState);
 
 const DONATE_LOGO_IMAGE_URL = 'https://donorbox.org/images/white_logo.svg';
 
+const showDonateCampaign = false;
+
 if (
+  showDonateCampaign &&
   window.location.href.indexOf('full') === -1 &&
   window.location.href.indexOf('embed') === -1
 ) {

client/utils/rename-variable.js

@@ -46,9 +46,6 @@ function startRenaming(cm, ast, fromPos, newName, oldName) {
 
       const startIndex = node.start;
       const endIndex = node.end;
-
-      if (node.name !== oldName) return;
-
       const pos = cm.posFromIndex(startIndex);
 
       if (
@@ -57,19 +54,15 @@ function startRenaming(cm, ast, fromPos, newName, oldName) {
           parent.type === 'ArrowFunctionExpression') &&
         parent.params.some((p) => p.type === 'Identifier' && p.name === oldName)
       ) {
-        if (!parent.params.includes(node)) {
-          return;
-        }
+        if (!parent.params.includes(node)) return;
       }
 
       if (
         parent.type === 'MemberExpression' &&
         parent.property === node &&
         !parent.computed
       ) {
-        if (parent.object.type === 'ThisExpression' && !isBaseThis) {
-          return;
-        }
+        if (parent.object.type === 'ThisExpression' && !isBaseThis) return;
       }
 
       const thisContext = getContext(
@@ -84,6 +77,8 @@ function startRenaming(cm, ast, fromPos, newName, oldName) {
       let shouldRenameGlobalVar = false;
       const isThis = isThisReference(cm, ast, pos, oldName);
 
+      shouldRenameGlobalVar = isGlobal && thisContext === 'global';
+
       // Handle renaming inside classes
       if (isInsideClassContext) {
         const tempPos = {
@@ -121,14 +116,6 @@ function startRenaming(cm, ast, fromPos, newName, oldName) {
           isThis === isBaseThis &&
           baseContext === thisContext
         ) {
-          Object.entries(classMeta.methodVars || {}).forEach(
-            ([methodName, vars]) => {
-              if (!vars.includes(oldName) && thisContext === methodName) {
-                const shouldRenameMethodVar = true;
-              }
-            }
-          );
-
           shouldRename =
             thisContext === baseContext &&
             (currentMethodName === 'constructor' || shouldRenameGlobalVar);
@@ -162,7 +149,6 @@ function startRenaming(cm, ast, fromPos, newName, oldName) {
             isGlobal &&
             !Object.prototype.hasOwnProperty.call(thisScopeVars, oldName);
         }
-        shouldRenameGlobalVar = isGlobal && thisContext === 'global';
       }
       // Handle renaming outside classes
       else {
@@ -201,15 +187,13 @@ function startRenaming(cm, ast, fromPos, newName, oldName) {
           isBaseThis
         );
 
-        if (
-          isThisGlobal &&
-          thisContext in userDefinedFunctionMetadata &&
-          userDefinedFunctionMetadata[thisContext].params.some(
-            (param) => param.p === oldName
-          )
-        ) {
-          return;
-        }
+        const params = userDefinedFunctionMetadata[thisContext]?.params || [];
+        const hasParamNamedOldName = params.some((param) =>
+          typeof param === 'string'
+            ? param === oldName
+            : param?.name === oldName || param?.p === oldName
+        );
+        if (isThisGlobal && hasParamNamedOldName) return;
 
         const methodPath = path.findParent((p) => p.isClassMethod());
         let currentMethodName = null;

client/utils/showRenameDialog.jsx

@@ -1,6 +1,6 @@
 import announceToScreenReader from './ScreenReaderHelper';
 import p5CodeAstAnalyzer from './p5CodeAstAnalyzer';
-import { getClassContext, getContext, getAST } from './renameVariableHelper';
+import { getContext, getAST } from './renameVariableHelper';
 
 const allFuncs = require('./p5-reference-functions.json');
 

common/p5Versions.js

@@ -1,4 +1,4 @@
-export const currentP5Version = '1.11.10'; // Don't update to 2.x until 2026
+export const currentP5Version = '1.11.11'; // Don't update to 2.x until 2026
 
 // Generated from https://www.npmjs.com/package/p5?activeTab=versions
 // Run this in the console:
@@ -11,6 +11,7 @@ export const p5Versions = [
   '2.0.2',
   '2.0.1',
   '2.0.0',
+  '1.11.11',
   '1.11.10',
   '1.11.9',
   '1.11.8',

contributor_docs/README.md

@@ -1,23 +1,24 @@
 # Contributor Documentation
+
 This folder contains guides for contributing to the p5.js Web Editor. You don't need to know everything to get started—explore at your own pace! To begin, we highly recommend starting with the [Contribution Guide](https://github.com/processing/p5.js-web-editor/blob/develop/.github/CONTRIBUTING.md)!
 
 These guides aren't exhaustive, and do not cover all the possible ways you can contribute to a project. If you have an idea for how you'd like to help and don't see a guide for it here, you're welcome to add it to the "Documents to Create" list below by opening an issue!
 
-
 ## List of Documents
-* [Contribution Guide](https://github.com/processing/p5.js-web-editor/blob/develop/.github/CONTRIBUTING.md) - A place to get started!
-* [Installation](installation.md) - A guide for setting up your development environment.
-* [Development](development.md) - A guide for contributing code to the codebase.
-* [Testing](./testing.md) - A guide for writing and running tests in the codebase. 
-* [Preparing an Issue](preparing_an_issue.md) - Instructions for creating and navigating issues.
-* [Preparing a Pull Request](preparing_a_pull_request.md) - Instructions for making a pull-request.
-* [Accessibility Guidelines](accessibility.md) - Guidelines for writing code to create an accessible application. 
-* [Translations Guidelines](translations.md) - Guidelines for translating the p5.js editor. 
-* [Deployment](deployment.md) - A guide to production deployment, and all platforms that are being used.
-* [Release](./release.md) - A guide to creating a production release.
-* [Typescript Migration](./typescript_migration.md) - About the Typescript Migration project.
 
+- [Contribution Guide](https://github.com/processing/p5.js-web-editor/blob/develop/.github/CONTRIBUTING.md) - A place to get started!
+- [Installation](installation.md) - A guide for setting up your development environment.
+- [Development](development.md) - A guide for contributing code to the codebase.
+- [Testing](./testing.md) - A guide for writing and running tests in the codebase.
+- [Preparing an Issue](preparing_an_issue.md) - Instructions for creating and navigating issues.
+- [Preparing a Pull Request](preparing_a_pull_request.md) - Instructions for making a pull-request.
+- [Accessibility Guidelines](accessibility.md) - Guidelines for writing code to create an accessible application.
+- [Translations Guidelines](translations.md) - Guidelines for translating the p5.js editor.
+- [Deployment](deployment.md) - A guide to production deployment, and all platforms that are being used.
+- [Release](./release.md) - A guide to creating a production release.
+- [Typescript Migration](typescript_migration.md) - About the Typescript Migration project.
 
 ## Documents to Create
-* Software Design Principles - reference [p5.js software design principles](https://github.com/processing/p5.js/blob/eb61f7a260531d17930de3c987949558ce242d35/contributor_docs/contributor_guidelines.md#software-design-principles)
-* File Structure - An explanation of the file structure of this application.
+
+- Software Design Principles - reference [p5.js software design principles](https://github.com/processing/p5.js/blob/eb61f7a260531d17930de3c987949558ce242d35/contributor_docs/contributor_guidelines.md#software-design-principles)
+- File Structure - An explanation of the file structure of this application.