Skip to content

Commit ffeb4e6

Browse files
authored
ci(release): eliminate bypassing of branch protection (#249)
1 parent 6a1a401 commit ffeb4e6

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,12 @@ jobs:
1414
- run: |
1515
echo "New version type: ${{ github.event.inputs.type }}"
1616
17-
- name: Branch Protection Bot - Temporarily disable "include administrators" branch protection
18-
uses: benjefferies/branch-protection-bot@1.0.9
19-
if: always()
20-
with:
21-
access_token: ${{ secrets.GH_RELEASE_TOKEN }}
22-
enforce_admins: false
23-
branch: main
24-
2517
- name: Setup checkout
2618
uses: actions/checkout@v4
2719
with:
20+
# Use a PAT to ensure that
21+
# commits are authored with a specific user
22+
# workflow run are triggered after git push
2823
token: ${{ secrets.GH_RELEASE_TOKEN }}
2924

3025
- name: Config git
@@ -78,13 +73,6 @@ jobs:
7873
run: |
7974
git push && git push --tags
8075
81-
- name: Branch Protection Bot - Reenable "include administrators" branch protection
82-
uses: benjefferies/branch-protection-bot@1.0.9
83-
if: always() # Force to always run this step to ensure "include administrators" is always turned back on
84-
with:
85-
access_token: ${{ secrets.GH_RELEASE_TOKEN }}
86-
enforce_admins: true
87-
branch: main
8876
- name: Send message to Slack channel
8977
if: success()
9078
uses: slackapi/slack-github-action@v1.24.0

0 commit comments

Comments
 (0)