Skip to content

Commit 5bd408a

Browse files
committed
Merge remote-tracking branch 'origin/main' into fix_maintainer_doc
2 parents 3cc9cd3 + 371cc1e commit 5bd408a

File tree

3 files changed

+31
-31
lines changed

3 files changed

+31
-31
lines changed

CONTRIBUTING.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ All members of our community are expected to follow our [Code of Conduct](https:
88

99
There are many ways to contribute:
1010

11-
- help people with the questions they ask on the [Github Issues](https://github.com/process-analytics/bpmn-visualization-R/issues)
12-
- submitting bug reports and feature requests in the [Github Issues](https://github.com/process-analytics/bpmn-visualization-R/issues/new)
11+
- help people with the questions they ask on the [GitHub Issues](https://github.com/process-analytics/bpmn-visualization-R/issues)
12+
- submitting bug reports and feature requests in the [GitHub Issues](https://github.com/process-analytics/bpmn-visualization-R/issues/new)
1313
- improving the README & documentation
1414
- writing code which can be incorporated into `bpmn-visualization-R` itself
1515

@@ -23,12 +23,12 @@ For all contributions, please respect the following guidelines:
2323

2424
3. Do not commit changes to files that are irrelevant to your feature or bugfix (eg: `.gitignore`).
2525

26-
7. Open a [GitHub Pull Request](CONTRIBUTING.md#open-a-pull-request) with your patches. (**1** pull request = **1** feature or bug)
26+
4. Open a [GitHub Pull Request](CONTRIBUTING.md#open-a-pull-request) with your patches. (**1** pull request = **1** feature or bug)
2727
We will review your contribution and respond as quickly as possible. Keep in mind that this is an open source project, and it may take us some time to get back to you. Your patience is very much appreciated.
2828

29-
8. If this is your 1st Pull Request, sign the [Contributor License Agreement](CONTRIBUTING.md#sign-the-contributor-license-agreement)
29+
5. If this is your 1st Pull Request, sign the [Contributor License Agreement](CONTRIBUTING.md#sign-the-contributor-license-agreement)
3030

31-
9. Be willing to accept criticism and work on improving your code.
31+
6. Be willing to accept criticism and work on improving your code.
3232

3333
**Working on your first Pull Request?** You can learn how from this *free* series [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github)
3434

@@ -45,26 +45,26 @@ git checkout -b 25-customize_overlays
4545
### Commit in the Pull Request
4646
There is no convention for the commit message in the Pull Request.
4747
The most important part is the title of the Pull Request, because:
48-
- Everyone must use Pull Request, no direct commit allowed on master branch
48+
- Everyone must use Pull Request, no direct commit allowed on main branch
4949
- The commits of a Pull Request are almost always squashed
5050
- The title of the Pull Request is used as proposal for the maintainer merging the Pull Request
5151

5252
### Open a Pull Request
5353

54-
At this point, you should switch back to your master branch and make sure it's up to date with `bpmn-visualization-R`
55-
`master` branch:
54+
At this point, you should switch back to your main branch and make sure it's up-to-date with `bpmn-visualization-R`
55+
`main` branch:
5656

5757
```sh
5858
git remote add upstream git@github.com:process-analytics/bpmn-visualization-R.git
59-
git checkout master
60-
git pull upstream master
59+
git checkout main
60+
git pull upstream main
6161
```
6262

63-
Then update your feature branch from your local copy of master, and push it!
63+
Then update your feature branch from your local copy of main, and push it!
6464

6565
```sh
6666
git checkout 25-customize_overlays
67-
git rebase master
67+
git rebase main
6868
git push --set-upstream origin 25-customize_overlays
6969
```
7070

@@ -94,7 +94,7 @@ Here's the suggested workflow:
9494

9595
```sh
9696
git checkout 25-customize_overlays
97-
git pull --rebase upstream master
97+
git pull --rebase upstream main
9898
git push --force-with-lease 25-customize_overlays
9999
```
100100

@@ -113,9 +113,9 @@ To regenerate this documentation after function comment updating, run this comma
113113
devtools::document()
114114
```
115115

116-
### bpmn-visualization-js update
116+
### bpmn-visualization TypeScript library update
117117

118-
The [bpmn-visualization-js](https://github.com/process-analytics/bpmn-visualization-js) dependency is automatically updated by the [Update BPMN Visualization version](.github/workflows/update_bpmn_visualization_version.yml) worklow when a new version of this library is released.
118+
The [bpmn-visualization](https://github.com/process-analytics/bpmn-visualization-js) dependency is automatically updated by the [Update bpmn-visualization version](.github/workflows/update_bpmn_visualization_version.yml) workflow when a new version of this library is released.
119119

120120
This generates a new Pull Request and notifies the reviewers.
121121

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
This project is an R package for visualizing process execution data on BPMN diagrams, using overlays, style customization and interactions.
2626

27-
It is made possible by [htmlwidgets](http://www.htmlwidgets.org/), which provides an easy-to-use framework for bringing together R and the [BPMN Visualization](https://github.com/process-analytics/bpmn-visualization-js) TypeScript library.
27+
It is made possible by [htmlwidgets](http://www.htmlwidgets.org/), which provides an easy-to-use framework for bringing together R and the [bpmn-visualization](https://github.com/process-analytics/bpmn-visualization-js) TypeScript library.
2828

2929
## ♻️ Usage
3030
### Installation

inst/htmlwidgets/bpmnVisualization.js

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
/**
2-
* Copyright 2021 Bonitasoft S.A.
3-
*
4-
* Licensed under the Apache License, Version 2.0 (the "License");
5-
* you may not use this file except in compliance with the License.
6-
* You may obtain a copy of the License at
7-
*
8-
* http://www.apache.org/licenses/LICENSE-2.0
9-
*
10-
* Unless required by applicable law or agreed to in writing, software
11-
* distributed under the License is distributed on an "AS IS" BASIS,
12-
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13-
* See the License for the specific language governing permissions and
14-
* limitations under the License.
15-
*/
1+
/*
2+
Copyright 2021 Bonitasoft S.A.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
1616

1717
HTMLWidgets.widget({
1818
name: "bpmnVisualization",

0 commit comments

Comments
 (0)