Skip to content

Implement "fancy" version statement#226

Merged
TheAssassin merged 8 commits intomasterfrom
TheAssassin/version-statement
Jan 26, 2018
Merged

Implement "fancy" version statement#226
TheAssassin merged 8 commits intomasterfrom
TheAssassin/version-statement

Conversation

@TheAssassin
Copy link
Collaborator

Fixes #210.

Also introduces a hint for users about the single quote parameters this
tool provides, most other CLI tools use double quotes for
non-single-char parameters.
After some highly annoying and time consuming tinkering with quotes and
escaping, the embedding of versioning data seems to work as intended
now.
@TheAssassin
Copy link
Collaborator Author

The "latest tag" detection code doesn't seem to work as intended yet. See https://travis-ci.org/probonopd/linuxdeployqt/builds/333877994#L870, -DLINUXDEPLOYQT_VERSION='"". That might be because the tags aren't available. https://travis-ci.org/probonopd/linuxdeployqt/jobs/333898312#L869 is a hint in that direction, too.

@TheAssassin TheAssassin merged commit e0ae780 into master Jan 26, 2018
@TheAssassin TheAssassin deleted the TheAssassin/version-statement branch January 26, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant