Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libp2p notifee to IpfsDHT #23

Open
Tracked by #54 ...
guillaumemichel opened this issue Jun 26, 2023 · 1 comment
Open
Tracked by #54 ...

Add libp2p notifee to IpfsDHT #23

guillaumemichel opened this issue Jun 26, 2023 · 1 comment
Labels
scope/required Feature required to match go-libp2p-kad-dht

Comments

@guillaumemichel
Copy link
Contributor

guillaumemichel commented Jun 26, 2023

https://github.com/libp2p/go-libp2p-kad-dht uses the libp2p notifee mechanism to add remote nodes to its routing table and peerstore. A similar mechanism should be implemented on the libp2p endpoint.

https://github.com/libp2p/go-libp2p-kad-dht/blob/978cb74f5fdf846e09d5769bb4dfb9f962135c38/subscriber_notifee.go

As it requires access to the libp2p host and it has an impact on the routing table, there are 2 solutions:

  • pass a routing table to the Libp2pEndpoint builder
  • implement the notifee at the IpfsDHT level, having access to both the routing table and the libp2p host.
@guillaumemichel guillaumemichel added the scope/required Feature required to match go-libp2p-kad-dht label Jun 27, 2023
@guillaumemichel guillaumemichel changed the title Add libp2p notifee to libp2pendpoint Add libp2p notifee to IpfsDHT Jul 4, 2023
@iand
Copy link
Contributor

iand commented Jul 11, 2023

Will move issue to go-libp2p-kad-dht for KadDHT in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/required Feature required to match go-libp2p-kad-dht
Projects
Status: Planned
Development

No branches or pull requests

3 participants