Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use polars instead in examples #712

Open
adrinjalali opened this issue Nov 12, 2024 · 3 comments
Open

Use polars instead in examples #712

adrinjalali opened this issue Nov 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@adrinjalali
Copy link
Contributor

Modern examples at this point should be using polars instead really, instead of pandas. For instance, here: https://github.com/probabl-ai/skore/blob/main/examples/plot_01_getting_started.py

@thomass-dev
Copy link
Collaborator

thomass-dev commented Nov 13, 2024

I have nothing against, but what are the cons of using pandas in the example notebooks?
Can we use both instead?

@adrinjalali
Copy link
Contributor Author

At this point using polars on new code just seems old school since when starting a new project, we'd recommend users to start with polars anyway. It has better API and is faster, and narwhals basically mirrors its API.

@thomass-dev
Copy link
Collaborator

At this point using polars on new code just seems old school

*pandas, right?

For a better adoption, i would recommend to put example of both pandas and polars, and add a comment to recommend polars.

@tuscland tuscland added the needs-triage This has been recently submitted and needs attention label Nov 13, 2024
@rouk1 rouk1 added enhancement New feature or request and removed needs-triage This has been recently submitted and needs attention labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants