Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

implement log state circuit #552

Merged
merged 18 commits into from
Jun 30, 2022
Merged

implement log state circuit #552

merged 18 commits into from
Jun 30, 2022

Conversation

DreamWuGit
Copy link
Collaborator

@DreamWuGit DreamWuGit commented Jun 3, 2022 •
edited
Loading

change list:

  1. add is_field_tag_unchanged_column in state circuit for check field_tag diff
  2. add tx log constraint for state part
  3. add part of positive and negative tests
  4. fix address expression in fix address expression for log #581

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-eth-types Issues related to the eth-types workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member labels Jun 3, 2022
@github-actions github-actions bot removed crate-bus-mapping Issues related to the bus-mapping workspace member crate-eth-types Issues related to the eth-types workspace member labels Jun 8, 2022
@DreamWuGit DreamWuGit marked this pull request as ready for review June 8, 2022 09:04
@DreamWuGit DreamWuGit requested a review from miha-stopar as a code owner June 8, 2022 09:04
@icemelon icemelon mentioned this pull request Jun 8, 2022
Closed
9 tasks
@DreamWuGit DreamWuGit mentioned this pull request Jun 13, 2022
Merged
@DreamWuGit
Copy link
Collaborator Author

@ed255 or @miha-stopar Could you pls. have a look ? Thx !!

@miha-stopar
Copy link
Collaborator

@ed255 or @miha-stopar Could you pls. have a look ? Thx !!

Yes, sure, just started today. One question before I dive deeper - are there some specs corresponding to this PR?

@DreamWuGit
Copy link
Collaborator Author

@ed255 or @miha-stopar Could you pls. have a look ? Thx !!

Yes, sure, just started today. One question before I dive deeper - are there some specs corresponding to this PR?

@miha-stopar privacy-scaling-explorations/zkevm-specs#220 is related spec PR :)

@z2trillion z2trillion mentioned this pull request Jun 14, 2022
Closed
15 tasks
@DreamWuGit DreamWuGit mentioned this pull request Jun 15, 2022
Merged
@ed255
Copy link
Member

ed255 commented Jun 15, 2022

@z2trillion since you're also working on the state circuit I think it would be good if you can take a look at this PR :)

@DreamWuGit DreamWuGit force-pushed the log_state branch 2 times, most recently from a4c188b to c3aa98e Compare June 22, 2022 12:55
@DreamWuGit DreamWuGit mentioned this pull request Jun 22, 2022
Closed
icemelon
icemelon approved these changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miha-stopar @ed255 do you want to take another look?

@miha-stopar
Copy link
Collaborator

LGTM.

@miha-stopar @ed255 do you want to take another look?

LGTM!

ed255
ed255 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please @z2trillion / @miha-stopar can you check the corresponding spec and approve it as well if you see fit?

@ed255 ed255 merged commit d3c6769 into privacy-scaling-explorations:main Jun 30, 2022
@DreamWuGit DreamWuGit mentioned this pull request Jun 30, 2022
Closed
@icemelon icemelon deleted the log_state branch June 30, 2022 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lispc lispc lispc left review comments

@miha-stopar miha-stopar miha-stopar approved these changes

@icemelon icemelon icemelon approved these changes

@z2trillion z2trillion z2trillion approved these changes

@ed255 ed255 ed255 approved these changes

Assignees
No one assigned
Labels
crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DreamWuGit @miha-stopar @ed255 @icemelon @lispc @z2trillion