Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for github.dev #856

Open
m-abdelwahab opened this issue Sep 2, 2021 · 6 comments
Open

Add support for github.dev #856

m-abdelwahab opened this issue Sep 2, 2021 · 6 comments
Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/feature A request for a new feature. topic: vscode topic: wasm

Comments

@m-abdelwahab
Copy link

m-abdelwahab commented Sep 2, 2021

Problem

It would be nice to make the Prisma extension compatible with https://github.dev. So far, there's no syntax highlighting, formatting, etc. for schema.prisma files.

Screenshot of VS Code showing  tat Prisma is not supported as a web extension

Suggested solution

Make a web extension version. Guide from VS Code docs repo

Alternative

Use GitHub Codespaces where the extension is compatible.

@janpio janpio added kind/feature A request for a new feature. topic: vscode labels Sep 2, 2021
@tomhoule tomhoule added the domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. label Sep 3, 2021
@Jolg42
Copy link
Contributor

Jolg42 commented Nov 4, 2021

Found this restriction list https://code.visualstudio.com/api/extension-guides/web-extensions#web-extension-main-file
Screen Shot 2021-11-04 at 09 45 58

Here I can see that the most problematic ones are

  • Node.js globals and libraries such as process, os, setImmediate, path, util, url are not available at runtime.
  • Creating child processes or running executables is not possible.

We would need to

  • switch to the WASM build of prisma-fmt
  • check how to remove usage of the Node.js globals listed
  • telemetry is using child_process, so probably disabling it in this context or find another implementation
  • Not sure the file watcher implemented would work, could be disabled in this context.

@janpio
Copy link
Contributor

janpio commented Feb 10, 2022

This item from our blocker list is now taken care of:

  • switch to the WASM build of prisma-fmt

@FluorescentHallucinogen

This issue is closed now. Does this mean it's completely implemented and the VSCode plug-in can be used with https://vscode.dev and https://github.dev now?

@Jolg42
Copy link
Contributor

Jolg42 commented Feb 11, 2022

I'm not sure why it was closed actually, since on github.dev the extension is still marked with The 'Prisma' extension is not available in Visual Studio Code - Insiders for the Web.

@Jolg42 Jolg42 reopened this Feb 11, 2022
@Jolg42
Copy link
Contributor

Jolg42 commented Feb 11, 2022

Note that the extension works with GitHub Codespaces https://github.com/codespaces

@janpio
Copy link
Contributor

janpio commented Feb 11, 2022

I suspect @m-abdelwahab just misunderstood what I wrote. We'll keep this issue open and around and work on removing the other blockers when we have time and it makes sense from a priority perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/feature A request for a new feature. topic: vscode topic: wasm
Projects
None yet
Development

No branches or pull requests

5 participants