Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP Rename incorrectly maps field name and appends character #1771

Closed
kevintraver opened this issue Jun 19, 2024 · 4 comments · Fixed by #1780
Closed

LSP Rename incorrectly maps field name and appends character #1771

kevintraver opened this issue Jun 19, 2024 · 4 comments · Fixed by #1780
Assignees
@Druue
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/regression A reported bug in functionality that used to work before. tech/typescript Issue for tech TypeScript. topic: @map topic: rename LSP rename
Milestone
5.17.0

Comments

@kevintraver
Copy link

Bug description

LSP Rename incorrectly maps field name and appends character

How to reproduce

use LSP Rename code action to rename dateAdded to addedDate

dateAdded          DateTime? @db.DateTime

Result

addedDate          DateTime? @db.DateTim @map("dateAdded")e

Expected behavior

addedDate          DateTime? @db.DateTime @map("dateAdded")

Prisma information

Version: 15.5.0

Environment & setup

  • Editor: Neovim
  • Editor version: 0.10.0
@kevintraver
Copy link
Author

I think it might have something to do with this change: fe081ac

@Druue Druue added bug/2-confirmed Bug has been reproduced and confirmed. kind/regression A reported bug in functionality that used to work before. tech/typescript Issue for tech TypeScript. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. topic: rename LSP rename topic: @map labels Jul 10, 2024
@Druue
Copy link
Contributor

Druue commented Jul 10, 2024

Hey @kevintraver, I can indeed confirm this :/
Looks like that change is the culprit indeed

Screen.Recording.2024-07-11.at.01.34.46.mov

@Druue Druue mentioned this issue Jul 16, 2024
Merged
@Druue Druue added this to the 5.17.0 milestone Jul 16, 2024
@Druue Druue self-assigned this Jul 16, 2024
@Druue
Copy link
Contributor

Druue commented Jul 16, 2024 •
edited
Loading

This fix will be part of the 5.17.0 release and is already on our latest version of Insiders. (Though I see you use nvim so not sure how long that takes to propagate there)

Screen.Recording.2024-07-16.at.12.02.25.mov

@kevintraver
Copy link
Author

It appears fixed! 🎉

This was referenced Aug 7, 2024
Merged
Merged
@prathik2401 prathik2401 mentioned this issue Aug 7, 2024
Merged
@folkmoz folkmoz mentioned this issue Aug 7, 2024
Open
@Cabreira97 Cabreira97 mentioned this issue Aug 7, 2024
Merged
@lryanle lryanle mentioned this issue Aug 7, 2024
Open
@origranot origranot mentioned this issue Aug 7, 2024
Merged
@pshaddel pshaddel mentioned this issue Aug 7, 2024
Open
@kevinanielsen kevinanielsen mentioned this issue Aug 7, 2024
Merged
@Jamesp918 Jamesp918 mentioned this issue Aug 7, 2024
Open
This was referenced Aug 8, 2024
Open
Open
This was referenced Aug 8, 2024
Open
Open
@Jeremygu2000 Jeremygu2000 mentioned this issue Aug 13, 2024
Open
@MohakBajaj MohakBajaj mentioned this issue Aug 13, 2024
Merged
@laravel2004 laravel2004 mentioned this issue Sep 18, 2024
Open
@tito-Saptarshi tito-Saptarshi mentioned this issue Sep 18, 2024
Open
@pshaddel pshaddel mentioned this issue Sep 18, 2024
Open
@Erik-EFL Erik-EFL mentioned this issue Sep 18, 2024
Open
This was referenced Sep 18, 2024
Closed
Closed
Open
Closed
@WontonSam WontonSam mentioned this issue Sep 23, 2024
Open
@trishantpahwa trishantpahwa mentioned this issue Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@folkmoz folkmoz mentioned this issue Sep 24, 2024
Open
@lryanle lryanle mentioned this issue Sep 24, 2024
Open
@laravel2004 laravel2004 mentioned this issue Sep 24, 2024
Open
@cibedex cibedex mentioned this issue Sep 24, 2024
Open
@Erik-EFL Erik-EFL mentioned this issue Sep 24, 2024
Open
@pshaddel pshaddel mentioned this issue Sep 24, 2024
Open
This was referenced Sep 26, 2024
Open
Open
This was referenced Sep 29, 2024
Open
Open
@origranot origranot mentioned this issue Oct 2, 2024
Closed
@davidebukali davidebukali mentioned this issue Oct 3, 2024
Open
@yashanand167 yashanand167 mentioned this issue Oct 5, 2024
Merged
@Bidaya0 Bidaya0 mentioned this issue Oct 13, 2024
Open
@origranot origranot mentioned this issue Oct 25, 2024
Closed
@0xlynix 0xlynix mentioned this issue Oct 26, 2024
Open
@WontonSam WontonSam mentioned this issue Nov 1, 2024
Open
@folkmoz folkmoz mentioned this issue Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Druue Druue

Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/regression A reported bug in functionality that used to work before. tech/typescript Issue for tech TypeScript. topic: @map topic: rename LSP rename
Projects
None yet
Milestone
5.17.0
Development

Successfully merging a pull request may close this issue.

fix(LS): rename where map doesn't exist prisma/language-tools
2 participants
@kevintraver @Druue