Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file watcher for macOS #1493

Open
Jolg42 opened this issue Aug 10, 2023 · 0 comments
Open

Improve file watcher for macOS #1493

Jolg42 opened this issue Aug 10, 2023 · 0 comments
Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: file watching

Comments

@Jolg42
Copy link
Contributor

Jolg42 commented Aug 10, 2023

We already did the improvement for Windows and Linux (see PR) but not for macOS where it would need some specific logic.

For Windows and Linux we switched completely to the new file watcher, because the old one was broken we are now watching the artifact created by prisma generate.

For macOS the "old" file watcher is still used and working, the suggestion would be to also watch the generate artifact on top of that so the people using older versions of Prisma won't have to downgrade their Prisma VS Code extension version to make it work again.

The code is here

if (os.platform() === 'darwin' && rootPath !== undefined) {

@Jolg42 Jolg42 added kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. topic: file watching labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: file watching
Projects
None yet
Development

No branches or pull requests

1 participant