Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 preview feature flags are deprecated, but all are underlined yellow #1211

Open
janpio opened this issue Jul 30, 2022 · 2 comments
Open

2 preview feature flags are deprecated, but all are underlined yellow #1211

janpio opened this issue Jul 30, 2022 · 2 comments
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. tech/engines Issue for tech Engines. topic: validation

Comments

@janpio
Copy link
Contributor

janpio commented Jul 30, 2022

image

but only

image
@janpio janpio added bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. topic: validation domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. labels Aug 4, 2022
@Druue
Copy link
Contributor

Druue commented Dec 9, 2022

Yep, can confirm! This is likely an issue in how we handle diagnostic spans in the psl (in engines). It seems like the span is just being applied to the whole array itself rather than to the individual fields.
Possibly here

image

image

@Druue Druue added bug/2-confirmed Bug has been reproduced and confirmed. tech/engines Issue for tech Engines. and removed bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. labels Dec 9, 2022
@tomhoule
Copy link
Contributor

Can confirm this is an artifact of the SchemaAst in engines being lossy. We want to replace that data structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. tech/engines Issue for tech Engines. topic: validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janpio @tomhoule @Druue