Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on _events, use .eventNames() instead when it's present. #6

Closed
ChALkeR opened this issue Mar 15, 2016 · 1 comment
Closed

Don't rely on _events, use .eventNames() instead when it's present. #6

ChALkeR opened this issue Mar 15, 2016 · 1 comment

Comments

@ChALkeR
Copy link

ChALkeR commented Mar 15, 2016

EventEmitter.prototype.eventNames was added in nodejs/node#5617 an will be available in Node.js 6.0 and later.

You should probably check for its presense and use that instead of manually listing EventEmitter.prototype._events in index.js#L81-L83, so you won't be hitting undocumented internal API.
This was referenced Mar 16, 2016
Merged
Merged
3rd-Eden added a commit that referenced this issue Nov 17, 2016
@3rd-Eden
Merge pull request #7 from unshiftio/gh-6
e6c1c41 
EventEmitter#eventNames() and Symbol support
@lpinca
Copy link
Member

lpinca commented Nov 17, 2016

Closing as #7 has been merged.
Thanks!

@lpinca lpinca closed this as completed Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChALkeR @lpinca