Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVC] Consider setting a max-width on breadcrumbs to help with long breadcrumb items #3128

Open
joshblack opened this issue Oct 2, 2024 · 2 comments
Assignees
Labels
bug Something isn't working rails size: sand

Comments

@joshblack
Copy link
Member

Context from Slack: https://github.slack.com/archives/CSGAVNZ19/p1727849002947669

In certain situations, a breadcrumb item may be long like on this page: https://github.com/actions/setup-node/pkgs/container/setup-node/276316120?tag=sha256-c6641e273d9f0bb6098ec9bc014e17251310b74fe49f2e082364cdcb044a7814

In these scenarios, the breadcrumbs component will overflow the page. Based on the conversation in Slack, it'd be great if we could set a max-width (or something similar) on the item so that this does not occur.

@joshblack joshblack added the bug Something isn't working label Oct 2, 2024
@lesliecdubs
Copy link
Member

Notes from Primer triage: we can just apply a max-width, no concerns about losing content that gets cut off. Suggestion from the Slack thread:

We could fix this by adding max-width: 100%; to the breadcrumb-item.

@lesliecdubs
Copy link
Member

lesliecdubs commented Oct 7, 2024

This came up in Primer Brand as a potential accessibility issue: https://github.com/github/primer/issues/3755.

We'll add this to the PVC accessibility remediation batch (via addition to that work's project board https://github.com/orgs/github/projects/13460/views/4) to be looked into.

@lesliecdubs lesliecdubs changed the title Consider setting a max-width on breadcrumbs to help with long breadcrumb items [PVC] Consider setting a max-width on breadcrumbs to help with long breadcrumb items Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rails size: sand
Projects
None yet
Development

No branches or pull requests

3 participants