Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align-end Action menu with long item label or description is misaligned #3000

Closed
bsatarnejad opened this issue Aug 9, 2024 · 3 comments
Closed
Labels
bug Something isn't working rails

Comments

@bsatarnejad
Copy link

bsatarnejad commented Aug 9, 2024

Steps to reproduce

  1. Go to the specification of the Action menu component and select Align end: https://primer-lookbook.github.com/view-components/lookbook/inspect/primer/alpha/action_menu/align_end
  2. Add a long label or description for an item

Current Behavior

As you see below, the action list is misaligned with button
Screenshot of an align-end primer action menu with long description, which is misaligned with button

Expected Behavior

The long text can be wrapped or truncated, and the action list should be aligned to the button. For example:
Screenshot of an example for align-end primer action menu with long description, which is aligned with button

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Uh oh! @bsatarnejad, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@lesliecdubs lesliecdubs added the bug Something isn't working label Aug 15, 2024
@lesliecdubs
Copy link
Member

Hi @bsatarnejad! Have you tried adding a size onto the ActionMenu to help control for this? We think "small" might help with this case. Let us know if that doesn't work.

@bsatarnejad
Copy link
Author

Hi @lesliecdubs
thanks a lot for your quick response.

I tested your solution, and it works. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rails
Projects
None yet
Development

No branches or pull requests

2 participants