Migrate Label to TypeScript

[colebemis]

This PR migrates the Label and LabelGroup component to TypeScript as part of the TypeScript refactor.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/cy2wmfyae
✅ Preview: https://primer-components-git-cb-ts-label.primer.now.sh

[emplums]

Looks good!

Quick question - are we still planning on removing all the prop types once the refactor is done? Is there any harm to keeping them in there so that non TS users at least get console warnings when a prop is used incorrectly? or is it more of a maintenance issue because we'd have to keep both in sync?

[emplums]

I didn't know you could do this syntax! Nice! 🙌

[colebemis]

@emplums

are we still planning on removing all the prop types once the refactor is done? Is there any harm to keeping them in there so that non TS users at least get console warnings when a prop is used incorrectly? or is it more of a maintenance issue because we'd have to keep both in sync?

Yeah, the maintaince cost of keeping the TypeScript types and propTypes in sync is pretty high. I've noticed that most of our propTypes are actually inaccurate right now. I don't think the benefits of runtime console warnings out weight the maintaince cost of keeping TS and propTypes in sync.

[changeset-bot]

🦋 Changeset detected

Latest commit: 397a46f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR