Skip to content

Conversation

@owenniblock
Copy link
Contributor

Relates to https://github.com/github/accessibility-audits/issues/10890

Blocks rollout of this PR: https://github.com/github/github/pull/383309

Changelog

N/A

New

Changed

The TooltipV2 no longer clears the existing aria-describedby property when using description type.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

It seems like the test I added isn't run using npm run test - I think because it's in the Ignore Modules list. I managed to run it with the following command:

npx vitest run "TooltipV2"

Merge checklist

Copilot AI review requested due to automatic review settings June 13, 2025 09:12
@owenniblock owenniblock requested a review from a team as a code owner June 13, 2025 09:12
@owenniblock owenniblock requested a review from jonrohan June 13, 2025 09:12
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2025

🦋 Changeset detected

Latest commit: 02ede7d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that when using the Tooltip in description mode, any existing aria-describedby values on the trigger are preserved and the tooltip’s ID is appended, rather than replaced.

  • Append tooltip ID to existing aria-describedby instead of overriding it
  • Add a unit test and a story to validate the merged description behavior
  • Update the changelog with a patch release entry

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/TooltipV2/tests/Tooltip.test.tsx Added test component and case for existing aria-describedby
packages/react/src/TooltipV2/Tooltip.tsx Changed aria-describedby logic to append tooltip ID
packages/react/src/TooltipV2/Tooltip.features.stories.tsx Added a feature story demonstrating external description usage
.changeset/two-aliens-wait.md Documented patch release for this change

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.21 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js 92.25 KB (+0.02% 🔺)

owenniblock and others added 2 commits June 13, 2025 11:37
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jonrohan jonrohan added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit 2317ca8 Jun 13, 2025
35 checks passed
@jonrohan jonrohan deleted the fix-aria-desc-override branch June 13, 2025 16:50
@primer primer bot mentioned this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants