Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-squids-hug.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

fix(SelectPanel): do not depend on id for selection comparison
6 changes: 4 additions & 2 deletions packages/react/src/SelectPanel/SelectPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -391,11 +391,13 @@ function Panel({
// For single-select modal, there is an intermediate state when the user has selected
// an item but has not yet saved the selection. We need to check for this state.
if (isSingleSelectModal) {
return intermediateSelected?.id === item.id
return intermediateSelected?.id !== undefined
? intermediateSelected.id === item.id
: intermediateSelected === item
}

// For single-select anchored, we just need to check if the item is the selected item
return selected?.id === item.id
return selected?.id !== undefined ? selected.id === item.id : selected === item
},
[selected, intermediateSelected, isSingleSelectModal],
)
Expand Down
Loading