Skip to content

AvatarStack #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emplums merged 32 commits into from
Oct 7, 2019
Merged

AvatarStack #575

emplums merged 32 commits into from
Oct 7, 2019

Conversation

@emplums
Copy link

@emplums emplums commented Oct 3, 2019 •
edited
Loading

Creates the AvatarStack component

Closes: #563

Implementation Checklist:

  • Handles 2 avatars
  • Handles more than 3 avatars
  • Passing in only one avatar doesn't break
  • Supports wrapping avatar in an anchor tag
  • Supports tooltips
  • Think through a11y of avatars
  • Supports right aligned stacks
  • Tests
  • Documentation
  • Types

@vercel
Copy link

vercel bot commented Oct 3, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-components-git-avatar-stack.primer.now.sh

@vercel vercel bot temporarily deployed to staging October 3, 2019 20:24 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 20:33 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 20:35 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 20:35 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 20:49 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 20:57 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 20:58 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 21:05 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 21:09 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 21:09 Inactive
@vercel vercel bot temporarily deployed to staging October 3, 2019 21:11 Inactive
emplums
emplums commented Oct 3, 2019
View reviewed changes
docs/content/AvatarStack.mdx Outdated
| Name | Type | Default | Description |
| :- | :- | :-: | :- |
| alt | String | | Adds accessible alternative text for avatars |
| src | String | | URL for image to be used in avatar |
Copy link
Author

@emplums emplums Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though these are just native img attributes, I'm listing them here because they are significantly important to be able to render the AvatarStack.Item component

@vercel vercel bot temporarily deployed to staging October 4, 2019 16:07 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 16:54 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 19:17 Inactive
@emplums
Copy link
Author

emplums commented Oct 4, 2019

Primer CSS:
image

Primer Components:
image

@vercel vercel bot temporarily deployed to staging October 4, 2019 19:19 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 19:20 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 19:23 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 22:17 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 22:19 Inactive
dmarcey
dmarcey reviewed Oct 6, 2019
View reviewed changes
dmarcey
dmarcey reviewed Oct 6, 2019
View reviewed changes
@vercel vercel bot temporarily deployed to staging October 7, 2019 17:26 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 17:27 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 18:14 Inactive
@dmarcey dmarcey self-requested a review October 7, 2019 18:17
dmarcey
dmarcey approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@dmarcey dmarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@emplums emplums merged commit b941584 into release-14.4.0 Oct 7, 2019
@emplums emplums deleted the avatar-stack branch October 7, 2019 18:17
@emplums emplums mentioned this pull request Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmarcey dmarcey dmarcey approved these changes

+1 more reviewer

@BinaryMuse BinaryMuse BinaryMuse left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emplums @BinaryMuse @dmarcey