Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #5219

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Release tracking #5219

merged 2 commits into from
Nov 5, 2024

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Nov 4, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@37.2.0

Minor Changes

  • #5168 b9749d4 Thanks @TylerJDev! - TreeView: Adds indication of no nodes in a tree item, allows for `aria-expanded even if the item is empty.

  • #5202 293c574 Thanks @hussam-i-am! - Update SubNav component to use CSS modules behind the feature flag primer_react_css_modules_team

Patch Changes

@primer primer bot requested a review from a team as a code owner November 4, 2024 17:38
@primer primer bot requested a review from siddharthkp November 4, 2024 17:38
Copy link
Contributor

github-actions bot commented Nov 4, 2024

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass on this pull request
  • Docs and Storybook open in a browser
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🌏 Integration tests

  • Successful integration test with github/github as a primary consumer of Primer React (automated pull request)
    • Verify all CI checks have passed on automated pull request
    • Manually test critical paths in the review-lab
    • Manually test release-specific bugfixes and/or features work as described in the review-lab

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Upgrade @primer/react version at github/github

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes on the weekly release tracking issue. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to the next release conductor as well as maintainers.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5219 November 4, 2024 17:40 Inactive
Copy link
Contributor

github-actions bot commented Nov 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.48 KB (0%)
packages/react/dist/browser.umd.js 98.91 KB (0%)

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests are passing 🎉

@siddharthkp siddharthkp added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 5, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5219 November 5, 2024 15:15 Inactive
@siddharthkp siddharthkp added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit d6bf8b1 Nov 5, 2024
44 checks passed
@siddharthkp siddharthkp deleted the changeset-release/main branch November 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant