Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Radio): Convert Radio to css modules behind feature flag #5187

Merged
merged 4 commits into from
Oct 30, 2024
Merged

feat(Radio): Convert Radio to css modules behind feature flag #5187

merged 4 commits into from
Oct 30, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 29, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4298

Changelog

Changed

Convert Radio to css modules behind feature flag

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan @joshblack
@randall-krauskopf @hussam-i-am
Convert radio to CSS modules
9a9d220 
Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: Randall Krauskopf <randall-krauskopf@users.noreply.github.com>
Co-authored-by: Hussam Ghazzi <hussam-i-am@github.com>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3051589

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 29, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5187 October 29, 2024 16:31 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.42 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 97.79 KB (+0.03% 🔺)

@primer-integration
Copy link

primer-integration bot commented Oct 29, 2024 •
edited
Loading

🟢 golden-jobs completed with status success.

@jonrohan jonrohan changed the title Convert radio to CSS modules feat(Radio): Convert Radio to css modules behind feature flag Oct 29, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5187 October 29, 2024 19:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5187 October 29, 2024 19:32 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349165

@jonrohan jonrohan marked this pull request as ready for review October 29, 2024 20:40
@jonrohan jonrohan requested a review from a team as a code owner October 29, 2024 20:40
joshblack
joshblack approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me if things are 💯 downstream, the only thing that I can think of is if we need to wrap nested styles in :where() because their specificity may win out if anyone is trying to target checked or disabled styles

@jonrohan jonrohan added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 2ab7b9e Oct 30, 2024
43 checks passed
@jonrohan jonrohan deleted the css_modules_convert_radio branch October 30, 2024 19:24
@primer primer bot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @joshblack