Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Button): Move Button CSS module feature flag from staff to ga #5086

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 8, 2024

Changelog

Changed

Moves ButtonBase css modules feature flag from staff to ga

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 82fea93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5086 October 8, 2024 18:32 Inactive
Copy link
Contributor

github-actions bot commented Oct 8, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.1 KB (+0.01% 🔺)
packages/react/dist/browser.umd.js 97.37 KB (-0.12% 🔽)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to test this canary at dotcom to make sure we don't introduce any regression to GA via the css modules or is it not necessary here?

@jonrohan jonrohan changed the title Move Button CSS module feature flag from staff to ga chore(Button): Move Button CSS module feature flag from staff to ga Oct 18, 2024
@jonrohan jonrohan added this pull request to the merge queue Oct 18, 2024
@jonrohan
Copy link
Member Author

Do you think we need to test this canary at dotcom to make sure we don't introduce any regression to GA via the css modules or is it not necessary here?

Not necessary

Merged via the queue into main with commit 96ce586 Oct 18, 2024
45 checks passed
@jonrohan jonrohan deleted the css_module_button_ga branch October 18, 2024 23:41
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants