Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix(Avatar): Changed rounded border calculation for the "square" Avatar to better align with existing border styles #5077

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 7, 2024

Fixes an issue I noticed in #5070 where the rounded corners of the "square" Avatar don't match the unflagged version.

You can see the problem this change is trying to fix in the Header storybook example with flag off vs with staff flag.

Changelog

Changed

Changed rounded border calculation for the "square" Avatar to better align with existing border styles

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner October 7, 2024 17:28
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: f43f926

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 7, 2024
@jonrohan jonrohan requested review from langermank and removed request for siddharthkp October 7, 2024 17:28
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.93 KB (0%)
packages/react/dist/browser.umd.js 97.12 KB (0%)

@jonrohan
Copy link
Member Author

jonrohan commented Oct 7, 2024

@langermank you can see the difference here if you look at Header storybook with flag off vs with staff flag.

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of clamp!

@jonrohan jonrohan added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 6490b27 Oct 7, 2024
33 checks passed
@jonrohan jonrohan deleted the avatar_rounded_border_fix branch October 7, 2024 18:57
@primer primer bot mentioned this pull request Oct 7, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants