Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugFix: When the feature flag is enabled and sx prop is passed in use, Box #5068

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 4, 2024

Fixes an issue when the flag is enabled and an sx prop is passed in, we want to still process the sx.

Changelog

Changed

When the feature flag is enabled and sx prop is passed in use the Box component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner October 4, 2024 18:07
Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: a4ade5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.76 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 97.08 KB (+0.08% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5068 October 4, 2024 18:10 Inactive
@jonrohan jonrohan added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 5f7bd0b Oct 4, 2024
32 checks passed
@jonrohan jonrohan deleted the toggle_styled_component_sx_prop_fix branch October 4, 2024 20:19
@primer primer bot mentioned this pull request Oct 4, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants