Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ButtonGroup): Migrate ButtonGroup component to use CSS modules behind the primer_react_css_modules_team feature flag #5001

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

jonrohan
Copy link
Member

Closes https://github.com/github/primer/issues/3960

Changelog

Changed

Migrate ButtonGroup component to use CSS modules behind the primer_react_css_modules_team feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 0541d46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 20, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5001 September 20, 2024 19:44 Inactive
Copy link
Contributor

github-actions bot commented Sep 20, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.03 KB (+0.26% 🔺)
packages/react/dist/browser.umd.js 98.17 KB (-0.01% 🔽)

@jonrohan jonrohan marked this pull request as ready for review September 20, 2024 19:47
@jonrohan jonrohan requested a review from a team as a code owner September 20, 2024 19:47
@github-actions github-actions bot temporarily deployed to storybook-preview-5001 September 20, 2024 19:49 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jonrohan jonrohan added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 597d285 Sep 23, 2024
32 checks passed
@jonrohan jonrohan deleted the css_modules_button_group branch September 23, 2024 16:28
@primer primer bot mentioned this pull request Sep 23, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants