Skip to content

TooltipV2: Use [disabled] selector to check for disabled elements #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

TylerJDev
Copy link
Member

A bug in Jest was causing a false positive when using :disabled, this is now fixed by using [disabled] instead.

Context for the false positive: dperini/nwsapi#125

Changelog

Changed

  • Uses [disabled] instead of :disabled

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@TylerJDev TylerJDev requested a review from a team as a code owner September 16, 2024 12:57
Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 028e686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.42 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 97.69 KB (-0.04% 🔽)

@TylerJDev TylerJDev changed the title TooltipV2: Use [disabled] selector to check for disabled elements #4961 TooltipV2: Use [disabled] selector to check for disabled elements Sep 16, 2024
@TylerJDev TylerJDev mentioned this pull request Sep 16, 2024
13 tasks
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@TylerJDev TylerJDev added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 98d3d13 Sep 17, 2024
37 checks passed
@TylerJDev TylerJDev deleted the tooltip-add-selector branch September 17, 2024 20:48
@primer primer bot mentioned this pull request Sep 17, 2024
TylerJDev added a commit that referenced this pull request Sep 23, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants