Add missing link variant to Button
#4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7ad25a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…into button-link-variant
joshblack
approved these changes
Aug 6, 2024
Co-authored-by: Josh Black <joshblack@github.com>
mperrotti
approved these changes
Aug 6, 2024
Comment on lines
+35
to
+38
| <a | ||
| style={{color: 'var(--fgColor-link)', textDecoration: 'underline'}} | ||
| href="https://github.com/github/accessibility/blob/8b300b36d8bca28fd5e3e70ffa077a6f8ee65c05/docs/wiki/screen-reader-testing/dynamically-updated-buttons-support-april-2024.md" | ||
| > |
There was a problem hiding this comment.
Instead of manually styling these, we could use the inline prop on our Link component
Suggested change
| <a | |
| style={{color: 'var(--fgColor-link)', textDecoration: 'underline'}} | |
| href="https://github.com/github/accessibility/blob/8b300b36d8bca28fd5e3e70ffa077a6f8ee65c05/docs/wiki/screen-reader-testing/dynamically-updated-buttons-support-april-2024.md" | |
| > | |
| <Link | |
| inline | |
| href="https://github.com/github/accessibility/blob/8b300b36d8bca28fd5e3e70ffa077a6f8ee65c05/docs/wiki/screen-reader-testing/dynamically-updated-buttons-support-april-2024.md" | |
| > |
There was a problem hiding this comment.
It was competing with the Link story so I kind of quickly did this instead. Especially since its just for a note.. I'm going to leave it for now but we can fix it later if needed.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
linkvariant has been missing for ages. It's always existed in PVC. Just bringing it on over 😄Changelog
New
linkvariant to ButtonRollout strategy
Testing & Reviewing
Merge checklist