Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): add vrt for blankslate #4809

Merged
merged 2 commits into from
Aug 1, 2024
Merged

test(e2e): add vrt for blankslate #4809

merged 2 commits into from
Aug 1, 2024

Conversation

joshblack
Copy link
Member

Add VRT for Blankslate component before moving to CSS Modules

Changelog

New

  • Add e2e test for Blankslate for VRT and AAT

Changed

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

@joshblack joshblack requested a review from a team as a code owner August 1, 2024 20:55
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b710cd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added update snapshots skip changeset This change does not need a changelog labels Aug 1, 2024
@github-actions github-actions bot added the staff Author is a staff member label Aug 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.84 KB (0%)
packages/react/dist/browser.umd.js 96.18 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4809 August 1, 2024 21:00 Inactive
@primer primer bot requested a review from a team as a code owner August 1, 2024 21:03
langermank
langermank approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@joshblack joshblack added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit 2ab2b3c Aug 1, 2024
30 checks passed
@joshblack joshblack deleted the test/add-blankslate-e2e-tests branch August 1, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @langermank