Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): enable support for CSS Modules and emitting *.css files in bundle #4800

Merged
merged 10 commits into from
Aug 1, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jul 31, 2024

Closes https://github.com/github/primer/issues/3685

Changelog

New

  • Add support for emitting *.css files alongside *.js files in order to allow authoring styles in CSS Modules

Changed

Removed

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

We've been testing out support for this incrementally in dotcom. As a result, we've landed some upstream PRs to enable support for this work. In addition, we will try out a feature flag approach to test out style-only changes before rolling them out more broadly.

Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: e877f6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.84 KB (0%)
packages/react/dist/browser.umd.js 96.18 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4800 July 31, 2024 15:29 Inactive
@joshblack joshblack marked this pull request as ready for review July 31, 2024 15:53
@joshblack joshblack requested a review from a team as a code owner July 31, 2024 15:53
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY

@joshblack joshblack added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit 482b4d6 Aug 1, 2024
30 checks passed
@joshblack joshblack deleted the feat/add-css-modules-to-primer-react branch August 1, 2024 18:44
@primer primer bot mentioned this pull request Aug 1, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants