fix(Blankslate): update styles to prevent SSR hydration mismatch #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9a3040c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
bump @TylerJDev! |
broccolinisoup
approved these changes
Jul 15, 2024
| display: grid; | ||
| justify-items: center; | ||
| padding: var(--blankslate-outer-padding-block) var(--blankslate-outer-padding-inline); | ||
| } | ||
|
|
||
| .Blankslate[data-spacious='true'] { | ||
| --blankslate-outer-padding-block: var(--base-size-80); | ||
| --blankslate-outer-padding-inline: var(--base-size-40); | ||
| --blankslate-outer-padding-block: var(--base-size-80, 5rem); |
| @@ -128,7 +130,7 @@ function Blankslate({border, children, narrow, spacious}: BlankslateProps) { | |||
| This is a workaround so we can use `@container` without upgrading `styled-components` to 6.x | |||
| See [this comment](https://github.com/primer/react/pull/3869#discussion_r1392523030) for more info | |||
| */} | |||
| <style type="text/css">{BlankslateContainerQuery}</style> | |||
| <style type="text/css" dangerouslySetInnerHTML={{__html: BlankslateContainerQuery}} /> | |||
There was a problem hiding this comment.
This is very smart 🔥
I also think it is obscure to cause hydration mismatch when it is passed as children 😄
Merged
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Blankslate to address an SSR hydration mismatch issue that was occurring. When the styles were present as
childrenof a<style>tag, they were being serialized in a way that transformed the'to escaped sequences leading to a hydration mismatch. Updating this to usedangerouslySetInnerHTMLaddresses this issue.I also updated the styles to use fallbacks, where appropriate, so the component would render as expected without an explicit import to primitives.
Changelog
New
Changed
styletag inBlankslateto better support SSRBlankslate.Removed
Rollout strategy