refactor(Stack): write to single custom property for gap changes #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c902c03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
langermank
reviewed
May 13, 2024
|
bump @langermank when you get a sec 👀 |
Merged
khiga8
pushed a commit
that referenced
this pull request
May 31, 2024
* refactor(Stack): write to single custom property for gap changes * chore: add changeset * test: update style test * refactor(Stack): use primitive tokens directly with fallback value * test(Stack): update test with new fallback in custom property --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4587
Update the strategy for setting gap in
Stackto use a single custom property,--stack-gap, that is written to a stack gap value (e.g.--stack-gap-normal). This is an attempt at refactoring this code so that we are writing to this value across breakpoints so that tracing down why something is happening at a breakpoint is only one jump (finding where the property is set) instead of two jumps (finding the variable for the breakpoint, finding the value that is being set for it). Curious to hear if this approach seems more clear if they are the same 👀Changelog
New
Changed
StackRemoved
Rollout strategy
Testing & Reviewing
noneis set then it should benoneacross breakpoints