Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release-conductor): remove previous conductor after assigning new one #4588

Merged
merged 1 commit into from
May 13, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented May 13, 2024

Context https://github.com/github/primer/issues/3277

This PR updates our logic to only remove the reviewer after the new reviewer has been added. This is to see if this prevents our validation error from occurring 👀

Changelog

New

Changed

  • Remove the previous conductor, if one exists, after the new conductor has been added

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change to an internal action

Testing & Reviewing

  • Sadly the workflow_dispatch for this doesn't work so we'll have to run it manually once it's merged 😞

Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: b1b0ad5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label May 13, 2024
@joshblack joshblack changed the title Update assign_release_conductor.yml ci(release-conductor): remove previous conductor after assigning new one May 13, 2024
@joshblack joshblack marked this pull request as ready for review May 13, 2024 17:10
@joshblack joshblack requested a review from a team as a code owner May 13, 2024 17:10
@joshblack joshblack requested a review from jonrohan May 13, 2024 17:10
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.34 KB (0%)
packages/react/dist/browser.umd.js 88.65 KB (0%)

@joshblack joshblack enabled auto-merge May 13, 2024 17:13
@joshblack joshblack added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 272c0b8 May 13, 2024
38 of 39 checks passed
@joshblack joshblack deleted the joshblack-patch-1 branch May 13, 2024 17:26
JelloBagel pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants