BranchName: Add style for span and add v8 tokens #4556

lukasoppermann · 2024-05-03T11:30:19Z

Changelog

change branchName text color to fgColor-muted if as="span"

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2024-05-03T11:30:24Z

🦋 Changeset detected

Latest commit: 4b103cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-05-03T11:33:43Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	88.04 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js	88.38 KB (+0.11% 🔺)

siddharthkp · 2024-05-03T11:47:32Z

packages/react/src/BranchName/BranchName.tsx

  text-decoration: none;
-
+  &:is(span) {


Should we make this is not a instead of span?

There is also as=p in gh/gh 😅 (I'm not sure why exactly)
https://musical-adventure-wlr3n3k.pages.github.io/?name=branchname&attribute=as

you mean :is(:not(a)) ?

siddharthkp · 2024-05-03T11:48:07Z

packages/react/src/BranchName/BranchName.stories.tsx

+  <Stack align="start">
+    <BranchName href="#">branch_name</BranchName>
+    <BranchName as="span">branch_name as span</BranchName>
+  </Stack>


siddharthkp

Left a tiny (optional) comment!

Approving in advance :)

* add style for branchName as span adn add v8 tokens * added changeset * Update thin-ligers-turn.md * test(vrt): update snapshots * use not a instead of matching for span --------- Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: lukasoppermann <lukasoppermann@users.noreply.github.com>

* Add new props to `FormControl.Label` * Add conditional * Add changeset * Update docs json * Add more examples * chore(deps-dev): bump ejs from 3.1.9 to 3.1.10 (#4549) Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BranchName: Add style for span and add v8 tokens (#4556) * add style for branchName as span adn add v8 tokens * added changeset * Update thin-ligers-turn.md * test(vrt): update snapshots * use not a instead of matching for span --------- Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: lukasoppermann <lukasoppermann@users.noreply.github.com> * refactor(Banner): update region to use a dedicated aria-label (#4539) * refactor(Banner): update region to use a dedicated aria-label * chore: add changeset, update config to exclude codesandbox * feat: add aria-label to Banner * Update packages/react/src/Banner/Banner.test.tsx Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com> * Update packages/react/src/Banner/Banner.test.tsx Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com> * test: update test label with aria-label --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com> * chore(deps-dev): bump cross-env from 7.0.2 to 7.0.3 (#4561) Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 7.0.2 to 7.0.3. - [Release notes](https://github.com/kentcdodds/cross-env/releases) - [Changelog](https://github.com/kentcdodds/cross-env/blob/master/CHANGELOG.md) - [Commits](kentcdodds/cross-env@v7.0.2...v7.0.3) --- updated-dependencies: - dependency-name: cross-env dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @babel/plugin-transform-modules-commonjs (#4562) Bumps [@babel/plugin-transform-modules-commonjs](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-modules-commonjs) from 7.23.3 to 7.24.1. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.1/packages/babel-plugin-transform-modules-commonjs) --- updated-dependencies: - dependency-name: "@babel/plugin-transform-modules-commonjs" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump jest-fail-on-console from 3.1.1 to 3.2.0 (#4563) Bumps [jest-fail-on-console](https://github.com/ValentinH/jest-fail-on-console) from 3.1.1 to 3.2.0. - [Release notes](https://github.com/ValentinH/jest-fail-on-console/releases) - [Commits](ValentinH/jest-fail-on-console@v3.1.1...v3.2.0) --- updated-dependencies: - dependency-name: jest-fail-on-console dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(FeatureFlags): broaden feature flag type to accept undefined (#4554) * feat(FeatureFlags): loosen feature flag type to accept undefined * chore: add changeset * Update .changeset/grumpy-coats-worry.md --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * prevent form submit (#4551) * deprecate title prop on ActionList.Group component on docs (#4544) * chore: add hydro analytics to storybook (#4558) * chore: add hydro analytics to storybook * chore: use previewHead over managerHead * Update build-docs --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Revert "Revert "Add support for nested submenus to `ActionMenu`"" (#4486) * Revert "Revert "Add support for nested submenus to `ActionMenu` (#4386)" (#4472)" This reverts commit 82072eb. * just want a change to trigger rebuild --------- Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: Pavithra Kodmad <pksjce@github.com> * chore(deps): update typescript to 5.4.5 (#4568) Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Use dynamic height and width for dialogs (#4567) * Use dynamic height and width for dialogs * Update tall-forks-bathe.md --------- Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> * Make asterisk default, update story scenarios * Update packages/react/src/FormControl/FormControl.docs.json Co-authored-by: Owen Niblock <owenniblock@github.com> * Update packages/react/src/internal/components/InputLabel.tsx Co-authored-by: Owen Niblock <owenniblock@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lukas Oppermann <lukasoppermann@github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: lukasoppermann <lukasoppermann@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com> Co-authored-by: Armağan <broccolinisoup@github.com> Co-authored-by: Ian Sanders <iansan5653@github.com> Co-authored-by: Pavithra Kodmad <pksjce@github.com> Co-authored-by: Dusty Greif <dgreif@users.noreply.github.com> Co-authored-by: Owen Niblock <owenniblock@github.com>

add style for branchName as span adn add v8 tokens

a7d44d1

lukasoppermann requested a review from a team as a code owner May 3, 2024 11:30

lukasoppermann requested a review from camertron May 3, 2024 11:30

added changeset

717c84b

lukasoppermann requested a review from siddharthkp May 3, 2024 11:32

lukasoppermann temporarily deployed to github-pages May 3, 2024 11:35 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-4556 May 3, 2024 11:36 Inactive

lukasoppermann added the update snapshots label May 3, 2024

lukasoppermann self-assigned this May 3, 2024

lukasoppermann added the react label May 3, 2024

Update thin-ligers-turn.md

0c1d39e

siddharthkp reviewed May 3, 2024

View reviewed changes

siddharthkp approved these changes May 3, 2024

View reviewed changes

test(vrt): update snapshots

e47fe1a

lukasoppermann requested a review from a team as a code owner May 3, 2024 11:49

lukasoppermann requested a review from tbenning May 3, 2024 11:50

github-actions bot removed the update snapshots label May 3, 2024

primer bot temporarily deployed to github-pages May 3, 2024 11:53 Inactive

github-actions bot temporarily deployed to storybook-preview-4556 May 3, 2024 11:53 Inactive

siddharthkp changed the title ~~add style for branchName as span adn add v8 tokens~~ BranchName: Add style for span and add v8 tokens May 3, 2024

lukasoppermann enabled auto-merge May 3, 2024 12:25

lukasoppermann disabled auto-merge May 3, 2024 12:26

use not a instead of matching for span

4b103cc

lukasoppermann enabled auto-merge May 3, 2024 12:28

lukasoppermann deployed to github-pages May 3, 2024 12:31 — with GitHub Actions View deployment

github-actions bot deployed to storybook-preview-4556 May 3, 2024 12:31 View deployment

ericwbailey approved these changes May 3, 2024

View reviewed changes

lukasoppermann added this pull request to the merge queue May 3, 2024

Merged via the queue into main with commit 9a56727 May 3, 2024
30 checks passed

lukasoppermann deleted the fix-branchName-span-text-color branch May 3, 2024 20:18

primer bot mentioned this pull request May 3, 2024

Release tracking #4559

Merged

This was referenced Jun 11, 2024

[Snyk] Upgrade @primer/react from 36.18.0 to 36.19.0 JonathanXDR/Atom#27

Closed

[Snyk] Upgrade @primer/react from 36.18.0 to 36.19.1 JonathanXDR/Atom#29

Closed

This was referenced Jun 20, 2024

[Snyk] Upgrade @primer/react from 36.18.0 to 36.19.1 JonathanXDR/Atom#30

Closed

[Snyk] Upgrade @primer/react from 36.18.0 to 36.20.0 JonathanXDR/Atom#31

Closed

StemmlerSisters mentioned this pull request Jul 16, 2024

[Snyk] Upgrade @primer/react from 36.1.0 to 36.23.0 StemmlerSisters/documentation#5

Open

snyk-io bot mentioned this pull request Jul 17, 2024

[Snyk] Upgrade @primer/react from 36.11.0 to 36.23.0 Hawthorne001/documentation.npm#3

Open

julitabarelkowska mentioned this pull request Jul 17, 2024

[Snyk] Upgrade @primer/react from 36.11.0 to 36.23.0 julitabarelkowska/documentation#7

Open

Canadatechmanufacturing mentioned this pull request Jul 17, 2024

[Snyk] Upgrade @primer/react from 36.7.0 to 36.23.0 Canadatechmanufacturing/documentation#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BranchName: Add style for span and add v8 tokens #4556

BranchName: Add style for span and add v8 tokens #4556

lukasoppermann commented May 3, 2024 •

edited

Loading

changeset-bot bot commented May 3, 2024 •

edited

Loading

github-actions bot commented May 3, 2024 •

edited

Loading

siddharthkp May 3, 2024 •

edited

Loading

lukasoppermann May 3, 2024

siddharthkp May 3, 2024

siddharthkp May 3, 2024

siddharthkp left a comment

BranchName: Add style for span and add v8 tokens #4556

BranchName: Add style for span and add v8 tokens #4556

Conversation

lukasoppermann commented May 3, 2024 • edited Loading

Changelog

Rollout strategy

Testing & Reviewing

Merge checklist

changeset-bot bot commented May 3, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented May 3, 2024 • edited Loading

size-limit report 📦

siddharthkp May 3, 2024 • edited Loading

Choose a reason for hiding this comment

lukasoppermann May 3, 2024

Choose a reason for hiding this comment

siddharthkp May 3, 2024

Choose a reason for hiding this comment

siddharthkp May 3, 2024

Choose a reason for hiding this comment

siddharthkp left a comment

Choose a reason for hiding this comment

lukasoppermann commented May 3, 2024 •

edited

Loading

changeset-bot bot commented May 3, 2024 •

edited

Loading

github-actions bot commented May 3, 2024 •

edited

Loading

siddharthkp May 3, 2024 •

edited

Loading