Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "SelectPanel2: Use html dialog" #4099

Closed

Conversation

broccolinisoup
Copy link
Member

Reverts #4020

@broccolinisoup broccolinisoup requested review from a team and siddharthkp December 21, 2023 03:36
Copy link

changeset-bot bot commented Dec 21, 2023

⚠️ No Changeset found

Latest commit: 2d36acf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 104.87 KB (0%)
dist/browser.umd.js 105.44 KB (0%)

@mperrotti
Copy link
Contributor

What happened? Why did we have to revert?

@broccolinisoup
Copy link
Member Author

broccolinisoup commented Dec 22, 2023

What happened? Why did we have to revert?

Sorry @mperrotti for not providing details on the revert! The new dialog was breaking dotcom tests and I created this PR to test the release without the SelectPanel changes. After all, @siddharthkp found a solution (GitHub staff only link) to fix the tests so we are not reverting the PR 🎉 I'm closing this.

@broccolinisoup broccolinisoup deleted the revert-4020-drafts-selectpanel-html-dialog branch December 22, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants