Skip to content

Add animated prop to ProgressBar #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Add animated prop to ProgressBar #4061

merged 7 commits into from
Dec 20, 2023

Conversation

mperrotti
Copy link
Contributor

Relates to https://github.com/github/primer/issues/2683

Kapture 2023-12-14 at 14 58 16

Changelog

New

  • animated prop on ProgressBar

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested review from a team and pksjce December 14, 2023 20:14
Copy link

changeset-bot bot commented Dec 14, 2023

🦋 Changeset detected

Latest commit: aa8c0c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 14, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.87 KB (+0.14% 🔺)
dist/browser.umd.js 105.44 KB (+0.14% 🔺)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✨

export const Item = styled.span<ProgressProp & SxProp>`
width: ${props => (props.progress ? `${props.progress}%` : 0)};
background-color: ${get('colors.success.emphasis')};

@media (prefers-reduced-motion: no-preference) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this 💖

@mperrotti mperrotti added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit f46c071 Dec 20, 2023
@mperrotti mperrotti deleted the mp/animated-progress-bar branch December 20, 2023 21:15
@primer primer bot mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants