Skip to content

use BaseStyles provider in ConfirmationDialog #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

keithamus
Copy link
Contributor

Closes #4034

Changelog

New

Changed

use in confirm()

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@keithamus keithamus requested review from a team and mperrotti December 8, 2023 16:17
Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: 100e4da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 8, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 105.16 KB (+0.01% 🔺)
dist/browser.umd.js 105.68 KB (+0.01% 🔺)

@keithamus keithamus added this pull request to the merge queue Dec 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2023
@keithamus keithamus added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit 6497f71 Dec 8, 2023
@keithamus keithamus deleted the use-basestyles-provider-in-confirmationdialog branch December 8, 2023 23:46
@primer primer bot mentioned this pull request Dec 8, 2023
TylerJDev pushed a commit that referenced this pull request Dec 11, 2023
* use BaseStyles provider in ConfirmationDialog

* changeset
@primer primer bot mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non Portaled confirm() dialogs are unstyled.
2 participants