don't recreate hostElements each time #4033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a7900b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
mperrotti
reviewed
Dec 8, 2023
| @@ -150,7 +150,7 @@ export type ConfirmOptions = Omit<ConfirmationDialogProps, 'onClose'> & {content | |||
| async function confirm(themeProps: ThemeProviderProps, options: ConfirmOptions): Promise<boolean> { | |||
| const {content, ...confirmationDialogProps} = options | |||
| return new Promise(resolve => { | |||
| hostElement = document.createElement('div') | |||
| hostElement ||= document.createElement('div') | |||
There was a problem hiding this comment.
I've never used this operator. I love it!
Merged
TylerJDev
pushed a commit
that referenced
this pull request
Dec 11, 2023
* don't recreate hostElements each time * changeset
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4032
Changelog
New
Changed
Fixed
confirm()leaving<div>s in the DOM.Removed
Rollout strategy
Testing & Reviewing
Merge checklist