Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove main landmark from PageLayout.Content. #3675

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

radglob
Copy link
Contributor

@radglob radglob commented Aug 28, 2023

Reintroducing these changes which were introduced in #3154, but were reverted.

Closes https://github.com/github/primer/issues/1586

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@radglob radglob self-assigned this Aug 28, 2023
@radglob radglob requested review from a team and joshblack August 28, 2023 15:24
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: d04beb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack
Copy link
Member

joshblack commented Aug 28, 2023

@radglob what does the splash zone of this change look like upstream? Are there any changes we need to make in dotcom before landing this?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.65 KB (-0.01% 🔽)
dist/browser.umd.js 105.21 KB (-0.01% 🔽)

@radglob
Copy link
Contributor Author

radglob commented Aug 28, 2023

@radglob what does the splash zone of this change look like upstream? Are there any changes we need to make in dotcom before landing this?

I don't think we have any issues upstream at this point. Armagan had looked into it a bit, and the issue in dotcom was a test that was checking for a main landmark in the react-app element, but it was removed so should no longer be an issue.

@joshblack
Copy link
Member

@radglob sweet, sounds great! Opened up: https://github.com/github/github/pull/286317 for the last round of checks but otherwise LGTM! Will leave an approval on the PR once that goes green ✅

@radglob radglob added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit ade10e6 Aug 29, 2023
30 checks passed
@radglob radglob deleted the remove-pagelayout-content-main-landmark branch August 29, 2023 15:53
@primer primer bot mentioned this pull request Aug 28, 2023
@TylerJDev TylerJDev mentioned this pull request Aug 29, 2023
7 tasks
@primer primer bot mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants